Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new use_spin_nightly feature #49

Merged
merged 2 commits into from Jan 2, 2021
Merged

Add new use_spin_nightly feature #49

merged 2 commits into from Jan 2, 2021

Conversation

thalesfragoso
Copy link
Contributor

@thalesfragoso thalesfragoso commented Dec 31, 2020 •
edited

Workaround for #48, at least until we get rust-lang/cargo#8832

Closes #48

phil-opp
phil-opp reviewed Jan 2, 2021
View reviewed changes
Copy link
Member

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for reporting this issue and directly providing a fix!

The changes look good to me overall, I just think that we should enable the new use_spin_feature by default (see inline comment).

Cargo.toml Outdated Show resolved Hide resolved
@phil-opp
Copy link
Member

phil-opp commented Jan 2, 2021

Thank!

@phil-opp phil-opp merged commit 0e0a5fc into rust-osdev:master Jan 2, 2021
@phil-opp
Copy link
Member

phil-opp commented Jan 2, 2021

Published as v0.8.11.

@thalesfragoso thalesfragoso mentioned this pull request Jan 2, 2021
Closed
@thalesfragoso thalesfragoso deleted the spin-night branch January 2, 2021 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-opp phil-opp phil-opp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

const_mut_refs is forcing spinning_top
2 participants
@thalesfragoso @phil-opp