Skip to content
This repository has been archived by the owner on Jan 5, 2024. It is now read-only.

What repo should we follow? #13

Closed
hazendaz opened this issue Jun 22, 2023 · 23 comments
Closed

What repo should we follow? #13

hazendaz opened this issue Jun 22, 2023 · 23 comments
Assignees
Labels
highsource plugin question Further information is requested

Comments

@hazendaz
Copy link

I think https://github.com/evolvedbinary/jvnet-jaxb-maven-plugin should be flagged archived with notes to use this repo. Issues not open over there so hoping with your recent integration you could reach author to do that.

Now, then the upstream is problematic. Its moved again without any regard for far more support here. Maybe they just don't know. Opening similar issue there. For now this seems the most feature complete because it supports JakartaEE. The upstream still does not. Even mavens mojohaus variation supports jakartaEE. So I think this needs ironed out as its a bit confusing to users IMHO.

@phax
Copy link
Owner

phax commented Jun 22, 2023

Well, the history is simple:

  • highsource JAXB plugin seems to be stalled
  • I needed a fix and forked it
  • elaboratebytes wanted JAXB 3.0 support and I don't - they agreed to take over
  • I needed support for JAXB 4.0 and they didn't - so I took it back

It's confusing, I agree.

Edit: changed "highsource" to "elaboratebytes" in the third bullet point

@phax phax self-assigned this Jun 22, 2023
@phax phax added the question Further information is requested label Jun 22, 2023
@hazendaz
Copy link
Author

Thank you for the answer, this will certainly help others. Jaxb and the like are a tangled mess in general. We will continue using your version as its better future proofed.

@laurentschoelens
Copy link

Well, the history is simple:

* highsource JAXB plugin seems to be stalled

* I needed a fix and forked it

* highsource wanted JAXB 3.0 support and I don't - they agreed to take over

* I needed support for JAXB 4.0 and they didn't - so I took it back

It's confusing, I agree.

Hi @phax what fix did you need on highsource plugin ?
We are planning to do jaxb3 and jaxb4 support (both using jakarta packages) very soon, so if you found something that needed to be fixed on original project that is not based on jakarta migration, could you please tell us what it was or even more, provide a PR to fix it :)
Thanks

@phax
Copy link
Owner

phax commented Jul 5, 2023

Hi @laurentschoelens, with "we" you mean you are now part of the highsource committers?
My original intent is and was highsource#173

hth, Philip

@laurentschoelens
Copy link

I'm not (still) direct committer to highsource repositories (in comparison to mattprav) but I'm in direct contact with him and provide many PR to make the project go ahead with issues and migration.
I've seen you provide a PR (which you closed without merge) and the initial issue was open in 2019.
I'll try look at it and see if the issue is still opened on the project since many things changed from then (jdk11 and jdk17 support for example).
Maybe we'll provide a similar PR as you first do to fix and see if there's no other issue raised.

For example, I'm trying to work on highsource#244 which is a very old issue but I've tried to fix with a simple change on catalog resolution handling.

@laurentschoelens
Copy link

Hi @laurentschoelens, with "we" you mean you are now part of the highsource committers? My original intent is and was highsource#173

hth, Philip

Hi @phax
Waiting for my last PR to be merged and then will provide the same PR as yours for highsource/jaxb-tools project for issue highsource#173 since no problems found by integrating your code in plugin.
I'll try to keep you updated with it.

@phax
Copy link
Owner

phax commented Jul 6, 2023

Excellent, thank you

@laurentschoelens
Copy link

Hi @phax

PR provided to highsource repo but with modification in code since it may fails if you get files like
a.xsd / b.xsd / common-a.xsd and includes them in same order
it may return a.xsd / common-a.xsd / b.xsd -> which is not the correct order you specified.
It should be integrated in future milestone of jaxb-maven-plugin (2.0.4) and then in jakarta's version (v3 and v4)

Regards

@phax
Copy link
Owner

phax commented Aug 7, 2023

Okay thanks. What are your plans on Jakarta 3 + 4 integration? Will you add it as well?

@laurentschoelens
Copy link

Yes. We're consolidating all jaxb-related repos in jaxb-tools main repository.
Once done, we'll start migrating to jakarta 3 and then jakarta 4 with jdk11 baseline for the latest

@laurentschoelens
Copy link

@phax : in fact I finally find out why you had your issue.

codehaus-plexus/plexus-utils#70 :

File.list() does not guarantee any order: Reproducible Builds require reproducible scan result
Optionally sorting entries while scanning will provide a useful feature

The plexus-utils DirectoryScanner utils does not guarantee any order in returned files.
Knowing that, I've rewrite your PR in order to be sure that the includes order is kept after plexus-utils returns the file, even with wildcard characters, since I'll consider that if you put b/* in second position of includes, that means that the xsd files in b directory have to be loaded before whatever comes after that.

You can see the PR that shall be included in 2.0.4 release : highsource#287

@laurentschoelens
Copy link

Okay thanks. What are your plans on Jakarta 3 + 4 integration? Will you add it as well?

Hi @phax ,

We did cut off v2.0.4 of jaxb maven plugin which fixes your issue.
Next will finish consolidation and then jakarta support (v3 and then v4 with jdk11 baseline)

Could you test 2.0.4 if you can and confirm issue is fixed ?

Thanks

@phax
Copy link
Owner

phax commented Aug 15, 2023

Hi @laurentschoelens,
Thanks for the good news.
Unfortunately I cannot test it, because in the meantime I updated all my projects to Java 11 + Jakarta JAXB 4. Backporting would be too much effort, so I am waiting until you have support for Jakarta JAXB.... Good luck with that!

@laurentschoelens
Copy link

Hi @phax
V3 version of the plugin and tools released in highsource's repo
If you want to give it a try, feel free

@phax
Copy link
Owner

phax commented Oct 3, 2023

Thanks, I really do need V4 for full compliance - I'll wait it up :) Besides that, I am on vacation anyway for this month and will check back in November. Thanks for your efforts so far @laurentschoelens

@laurentschoelens
Copy link

Yep that was I've seen in another issue
V4 will get soon available in my opinion
I'll keep you updated

@laurentschoelens
Copy link

@phax v4 as been released ;-)

@phax
Copy link
Owner

phax commented Oct 10, 2023

Whoop whoop - I will have a look at it, when there is bad weather :)

@laurentschoelens
Copy link

Hi @phax
Did you manage to look at it ?
Regards
Laurent

@phax
Copy link
Owner

phax commented Oct 31, 2023

@laurentschoelens Nope - still on vacation (lucky me). Will be back on Thursday, packed with meeting untils the end of the week, so don't expect some insights before Nov 6th

@laurentschoelens
Copy link

@phax : hope everything is fine since your vacations ended.
Don't forget to look when you've got time 😄
Laurent

@phax phax reopened this Nov 10, 2023
@laurentschoelens
Copy link

Hi @phax
Hope you're going well.
Did you get some time to look at jaxb-tools repository ?

@phax
Copy link
Owner

phax commented Jan 5, 2024

Please follow https://github.com/highsource/jaxb-tools- it works for all my JAXB 4 requirements as a drop-in replacement

@phax phax closed this as completed Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
highsource plugin question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants