Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo: Update readme, setup typescript, setup jest #848

Open
11 of 13 tasks
FrederickEngelhardt opened this issue Jun 16, 2020 · 0 comments · Fixed by #849
Open
11 of 13 tasks

Monorepo: Update readme, setup typescript, setup jest #848

FrederickEngelhardt opened this issue Jun 16, 2020 · 0 comments · Fixed by #849
Assignees
Projects

Comments

@FrederickEngelhardt
Copy link
Contributor

FrederickEngelhardt commented Jun 16, 2020

Lerna setup

  • swap to lerna hoist option speed things up
  • clean up package version discrepancies
  • add update and update checking scripts for all lerna dependencies
  • add cleanup scripts for package-lock.json spawning to maintain latest versions each time we run lerna bootstrap.
  • add readme update regarding lerna installlation and what hoisting does.

Typescript setup

  • add monorepo compilation for JS and TS files for all packages
  • add initial typings for particle-cli package
  • use CommonJS as target
  • hybrid cjs and esm app research (see below)
  • json import refactor to pull in package.json for npm link in dist/package-name*

ESM & CJS targets for typescript

Did some research on commonjs and esm hybrid module support. This provides an option for modern browsers to use the ESM.

Doing so will make the testing and compilation a bit more complex. Example you have two targets, so you now have to create two different scripts for compilation and for testing.

Jest setup

  • add support for typescript
  • add support for normal js tests
  • example code to particle-cli package
@FrederickEngelhardt FrederickEngelhardt created this issue from a note in v11.0 (In progress) Jun 16, 2020
@FrederickEngelhardt FrederickEngelhardt self-assigned this Jun 16, 2020
@FrederickEngelhardt FrederickEngelhardt moved this from In progress to Pending Review(s) in v11.0 Jun 29, 2020
@FrederickEngelhardt FrederickEngelhardt moved this from Pending Review(s) to Done in v11.0 Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
v11.0
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant