Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix light-dom import reference. #382

Closed
wants to merge 1 commit into from
Closed

Conversation

tekante
Copy link
Member

@tekante tekante commented Apr 30, 2023

Description

Change the import reference to light-dom to avoid the following error on yarn run start:

✘ [ERROR] Could not resolve "../internal/light-dom"

    ../../outline/packages/outline-core/src/controllers/light-dom-styles.ts:3:33:
      3 │ import { addScopeToStyles } from '../internal/light-dom';
        ╵                                  ~~~~~~~~~~~~~~~~~~~~~~~

/code/issue-378/node_modules/esbuild/lib/main.js:1636
  let error = new Error(`${text}${summary}`);
              ^

Error: Build failed with 1 error:
../../outline/packages/outline-core/src/controllers/light-dom-styles.ts:3:33: ERROR: Could not resolve "../internal/light-dom"
    at failureErrorWithLog (/code/issue-378/node_modules/esbuild/lib/main.js:1636:15)
    at /code/issue-378/node_modules/esbuild/lib/main.js:1048:25
    at /code/issue-378/node_modules/esbuild/lib/main.js:1512:9
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errors: [
    {
      detail: undefined,
      id: '',
      location: {
        column: 33,
        file: '../../outline/packages/outline-core/src/controllers/light-dom-styles.ts',
        length: 23,
        line: 3,
        lineText: "import { addScopeToStyles } from '../internal/light-dom';",
        namespace: '',
        suggestion: ''
      },
      notes: [],
      pluginName: '',
      text: 'Could not resolve "../internal/light-dom"'
    }
  ],
  warnings: []
}

Fixes #378

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manually
  • Visual Testing
  • Automated Testing
  • Accessibility Testing

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2023

⚠️ No Changeset found

Latest commit: c05263d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 30, 2023

Deploy Preview for outlinejs ready!

Name Link
🔨 Latest commit c05263d
🔍 Latest deploy log https://app.netlify.com/sites/outlinejs/deploys/644dc8feb1921200080dcaa8
😎 Deploy Preview https://deploy-preview-382--outlinejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tekante tekante changed the title Fix light-dom import reference. WIP: Fix light-dom import reference. Apr 30, 2023
@tekante
Copy link
Member Author

tekante commented Apr 30, 2023

Commit c05263d fixes the error on yarn run start but it looks like it does not actually fix it for yarn run build so changing title of this to WIP since I don't see a way to convert this back to a draft PR

@tekante
Copy link
Member Author

tekante commented May 1, 2023

Based on https://github.com/phase2/outline/pull/385/files the changes in f0c5d51 and 8a049d2 are needed as well. Going to close this one in favor of #385

@tekante tekante closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors: light-dom
1 participant