Skip to content

Add a way to quote array shape keys. Quote characters that aren't whitelisted for array keys. #1664

Closed
@TysonAndre

Description

@TysonAndre
Member

E.g. render the array shape type (in issue messages) of [' ' => 'x'] as array{"\x20":string}

TODO: decide on a whitelist.

Activity

added
enhancementThis improves the quality of Phan's analysis of a codebase
on May 3, 2018
self-assigned this
on Mar 29, 2019
TysonAndre

TysonAndre commented on Mar 29, 2019

@TysonAndre
MemberAuthor

Or array{\x20:string} since backslashes aren't allowed, plus other escapes (\u..., \\, \n, etc)

added a commit that references this issue on Apr 21, 2019
51e5a1c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementThis improves the quality of Phan's analysis of a codebase

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Development

    Participants

    @TysonAndre

    Issue actions

      Add a way to quote array shape keys. Quote characters that aren't whitelisted for array keys. · Issue #1664 · phan/phan