fix: throw SQLException for #getBoolean BIT(>1) #2386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw SQLException instead of ClassCastException when calling
CallableStatement#getBoolean(int) on BIT(>1).
Currently when users call
CallableStatement#getBoolean(int)
on an out parameter of typeBIT(>1)
they getClassCastException
because the driver casts the result to aBoolean
without checking the type first. This works forBIT(1)
bit fails forBIT(>1)
because then the type currently isPGobject
. I know there are many related issues and PRs resolving around how we should treat bistring typesThis PR doesn't preclude any approach on these issues, it just changes the exception type for the current behavior.
All Submissions:
There are many related ones but I didn't find any for this specific issue.
Changes to Existing Features:
Users get
SQLException
instead ofClassCastException
. Users already need to catchSQLException
so hopefully the impact isn't too big. Additionally the combination ofCallableStatement
andBIT(>1)
may be quite low, otherwise we may have gotten bug reports.