add TCP No Delay option fixes Issue #2324 #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obourgain
added a commit
to obourgain/pgjdbc
that referenced
this pull request
Apr 20, 2022
In [pgjdbc#2341](pgjdbc#2341) the option to configure tcpNoDelay was added, with a default value of false. The previous value of this setting was true, as set in PGStream.changeSocket(Socket) with the following code: ``` // Submitted by Jason Venner <jason@idiom.com>. Disable Nagle // as we are selective about flushing output only when we // really need to. connection.setTcpNoDelay(true); ``` `changeSocket()` is called from the `PGStream` constructor, which is called in `ConnectionFactoryImpl`, and then later we overwrite the value with the one from the properties. We had a performance issue when upgrading from 42.2.24 to 42.3.3, and we suspected the issue in 42.3.2 and confirmed that by passing the property `tcpNoDelay=true` to the driver, the performance issue was fixed.
6 tasks
davecramer
pushed a commit
that referenced
this pull request
Apr 21, 2022
In [#2341](#2341) the option to configure tcpNoDelay was added, with a default value of false. The previous value of this setting was true, as set in PGStream.changeSocket(Socket) with the following code: ``` // Submitted by Jason Venner <jason@idiom.com>. Disable Nagle // as we are selective about flushing output only when we // really need to. connection.setTcpNoDelay(true); ``` `changeSocket()` is called from the `PGStream` constructor, which is called in `ConnectionFactoryImpl`, and then later we overwrite the value with the one from the properties. We had a performance issue when upgrading from 42.2.24 to 42.3.3, and we suspected the issue in 42.3.2 and confirmed that by passing the property `tcpNoDelay=true` to the driver, the performance issue was fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.