fix: allow OUT parameter registration when using CallableStatement na… #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Build pgjdbc 1.0.432 failed (commit b9f04cbeb7 by @gregn123) |
…tive CALL
Currently, using CallableStatement, the PGJDBC driver will allow invocation of procedures using
the native "call myproc(...)" syntax, provided the procedure only has IN parameters or no
parameters.
However, if the procedure has any INOUT parameters, then an attempt to invoke the
CallableStatement's registerOutParameter() method, which is required in order to register the OUT
part of the INOUT parameter, will fail with the following error:
This statement does not declare an OUT parameter. Use { ?= call ... } to declare one.
This fixes issue: pgjdbc#1545
|
❌ Build pgjdbc 1.0.434 failed (commit 215fb8f29b by @gregn123) |
Codecov Report
@@ Coverage Diff @@
## master #1561 +/- ##
============================================
+ Coverage 68.94% 69.05% +0.11%
- Complexity 4032 4042 +10
============================================
Files 179 179
Lines 16750 16758 +8
Branches 2740 2744 +4
============================================
+ Hits 11549 11573 +24
+ Misses 3931 3917 -14
+ Partials 1270 1268 -2 |
|
✅ Build pgjdbc 1.0.542 completed (commit 8a3bf60ef7 by @gregn123) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tive CALL
Currently, using CallableStatement, the PGJDBC driver will allow invocation of procedures using
the native "call myproc(...)" syntax, provided the procedure only has IN parameters or no
parameters.
However, if the procedure has any INOUT parameters, then an attempt to invoke the
CallableStatement's registerOutParameter() method, which is required in order to register the OUT
part of the INOUT parameter, will fail with the following error:
This statement does not declare an OUT parameter. Use { ?= call ... } to declare one.
This fixes issue: #1545