feat: Add cancelQuery() to PGConnection public interface #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1157 +/- ##
============================================
- Coverage 68.94% 68.93% -0.02%
+ Complexity 3775 3774 -1
============================================
Files 170 170
Lines 15757 15757
Branches 2577 2577
============================================
- Hits 10864 10862 -2
- Misses 3658 3659 +1
- Partials 1235 1236 +1 |
sehrope
force-pushed
the
add-cancel-query-to-pgconnection
branch
from
929ad71
to
8d7b7a0
Compare
Adds cancelQuery() to the extended public interface PGConnection to allow for issueing of cancels directly to connections rather than having to keep track of individual statements. The internals of the driver and the backend server already operate at a connection level (not a statement level) and this patch only exposes the existing cancelQuery() method publicly.
sehrope
force-pushed
the
add-cancel-query-to-pgconnection
branch
from
8d7b7a0
to
b8f1a2e
Compare
|
✅ Build pgjdbc 1.0.201 completed (commit db109455e3 by @sehrope) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cancelQuery()to the extended public interfacePGConnectionto allow for issuing of cancels directly to connections rather than having to keep track of individual statements. The internals of the driver and the backend server already operate at a connection level (not a statement level) and this patch only exposesthe existing cancelQuery() method publicly.
Exposing the
cancelQuery()publicly is mainly a convenience thing as it's already part of all the concrete implementations. This is how how the server handles cancellation (i.e. at the connection, not statement, level) so I don't foresee any long term baggage associated with exposing this. The backend functionality is not going away.There's been at least one other request for this in the past: #1084
Any thoughts on merging this in?