PgSQLXML setCharacterStream() results in null value

[felipe-louzas]

When using the setCharacterStream() method in the PgSQLXML class, the value sent to the database will be null.

The PgSQLXML.setCharacterStream() method needs to be altered to the following:

public synchronized Writer setCharacterStream() throws SQLException {
    checkFreed();
    initialize();
    _active = true; //this line needs to be added
    _stringWriter = new StringWriter();
    return _stringWriter;
  }

Details:

The PgSQLXML.setCharacterStream() code does not set the _active variable to true:

public synchronized Writer setCharacterStream() throws SQLException {
    checkFreed();
    initialize();
    _stringWriter = new StringWriter();
    return _stringWriter;
  }

When the PgPreparedStatement reads the SQLXML object, it calls the getString() method:

  public void setSQLXML(int parameterIndex, SQLXML xmlObject) throws SQLException {
    checkClosed();
    if (xmlObject == null || xmlObject.getString() == null) {
      setNull(parameterIndex, Types.SQLXML);
    } else {
      setString(parameterIndex, xmlObject.getString(), Oid.XML);
    }
  }

This in turn will call PgSQLXML.ensureInitialized() to move the data to the _data variable.

 public synchronized String getString() throws SQLException {
    checkFreed();
    ensureInitialized();
    return _data;
  }

However the PgSQLXML.ensureInitialized() method will simply return when _active is false;

 private void ensureInitialized() throws SQLException {
 // [...]
    // Is anyone loading data into us at the moment?
    if (!_active) {
      return;
    }
// [...]

[vlsi]

@felipe-louzas , thanks for the analysis. Would you please prepare a pull request & test to fix the issue?

[davecramer]

Fixed in #1608