Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #2592

Merged
merged 1 commit into from Sep 2, 2022
Merged

Spelling #2592

merged 1 commit into from Sep 2, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 14, 2022

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@57d8112#commitcomment-81170047

The action reports that the changes in this PR would make it happy: jsoref@e0ed387

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change? -- fwiw this link doesn't work

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew autostyleCheck checkstyleAll pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

CHANGELOG.md Show resolved Hide resolved
docker/postgres-server/docker-compose.yml Show resolved Hide resolved
docs/_includes/submenu_community.html Show resolved Hide resolved
docs/documentation/changelog.md Show resolved Hide resolved
docs/documentation/head/replication.md Show resolved Hide resolved
@@ -278,7 +278,7 @@ public void readWriteStream(int offset, byte[] data) throws SQLException, IOExce

@Test
public void testPattern() throws SQLException {
byte[] data = "abcdefghijklmnopqrstuvwxyx0123456789".getBytes();
byte[] data = "abcdefghijklmnopqrstuvwxyz0123456789".getBytes();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of thing happens way more often than I'd like, and pretty much every variation I run into has many hits in cs.github.com, but I'm still shocked by them when I see them.

@vlsi
Copy link
Member

vlsi commented Aug 14, 2022

I went through the changes, and I think they are good.
I think it would be valuable to have the check on PR basis

@davecramer
Copy link
Member

+1

* a nonexistent
* abcdefghijklmnopqrstuvwxyz
* able
* accepted
* accidentally
* actual
* applied
* artifacts
* assessors
* backwards
* because
* before
* between
* bootstrap
* certificates
* change
* character
* classes
* code
* columns
* committing
* connect
* connection
* constraint
* contains
* converting
* current
* customize
* decimal
* diagnostic
* directly
* encrypted
* escape
* example
* exceeded
* exceptions
* expected
* expression
* for
* format
* github
* gssapi
* guc
* handshake
* hit
* implementation
* infinity
* instantiation
* javascript
* kellerer
* length
* logical
* manager
* message
* millis
* non-pooling
* nonexistent
* nonexistentdatabase
* nonhiding
* normalized
* override
* package
* parameterized
* partitioned
* password
* physical
* position
* postgresql
* preprocessor
* previously
* privileges
* quarter
* regressions
* replication
* repository
* service
* should
* startup
* statements
* substitutions
* that
* the
* trace
* transfer
* truncate
* unimplemented
* unknown
* unprepared
* vacuum
* varchar
* version
* weight

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@vlsi
Copy link
Member

vlsi commented Aug 15, 2022

The failures above do not look like spelling-induced ones.

@davecramer davecramer merged commit 5c78edb into pgjdbc:master Sep 2, 2022
@jsoref jsoref deleted the spelling branch September 2, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants