Use GitHub Action for building RPM in Fedora Copr

[praiskup]

And fix the spec file which failed to build.

[praiskup]

COPR_PUSH_WEBHOOK secret needs to be added, with custom webhook (use PACKAGE = postgresql-jdbc):
https://copr.fedorainfracloud.org/coprs/g/pgjdbc/pgjdbc/integrations/
I can gpg-encrypt the webhook, and send it via e-mail.

[davecramer]

Hi @praiskup sure you can send it to me davecramer@gmail.com

Thanks

[praiskup]

E-mail sent, thanks!

[davecramer]

@praiskup I noticed some recent pushes. let me know when I can merge this

[praiskup]

If the GH secret is installed (PUSH webhook location), I think we can merge this.
I just fixed small typo in one script name that would fail the build.

[davecramer]

in the add webhook they ask if you want json encoded or form-url-encoded?

[praiskup]

This needs only adding a GitHub secret named COPR_PUSH_WEBHOOK=<URL>. The action itself creates the JSON request automatically.

[davecramer]

got it, give me a second

[davecramer]

done

[praiskup]

Thanks!
Then I think we can merge, and automatically build RPMs again (PUSH hook should build right now, and subsequent PRs should build, too). If not, I'll take a look at fix.

[praiskup]

Sorry, @davecramer PUSH doesn't work because I made a mistake — the last
part of the webhook needs to be ../postgresql-jdbc/, not ../pgjdbc/.
Could you please update it once more? Please trim any whitespaces, if copy-pasted.

[davecramer]

done

[praiskup]

Works! Thank you for the help.
https://copr.fedorainfracloud.org/coprs/g/pgjdbc/pgjdbc/build/3277472/

[davecramer]

This awesome!

[davecramer]

@praiskup do we really want to build this for every PR ?

[praiskup]

It shouldn't be a problem IMO. Is it causing some troubles?

[praiskup]

Hm, I can see there's e.g. this build failure:
https://download.copr.fedorainfracloud.org/results/@pgjdbc/pgjdbc/fedora-rawhide-x86_64/03288915-postgresql-jdbc/builder-live.log.gz
There's something racy in the test suite probably?

If the run fails, you are free to ignore the error. But before the PR is merged, that's the best chance to fix any potential problems.

[davecramer]

there are some race conditions that have failures, yes.

My issue with every PR is that it slows down the checks.

[praiskup]

Can we make the check non-blocking (if it is)? I don't think we always have to wait for the test to pass. Or should there be some trigger button for this to start?

[davecramer]

Two options. There is an option where an action is initiated by a button, alternatively there should be an action which is initiated by a merge (at least I'd hope so).

[praiskup]

Yes, I intentionally configured both PR and merges configured both
I'm just afraid that "merge" event in isolation is too late. In most cases, 10 minutes tasks don't play
huge role. And anytime else you can ignore the running task?

[praiskup]

Of course, if you prefer to merge only events, feel free to drop the pull_request hook. From Copr's perspective (the main task computation is done there), it is OK to handle all the PRs.