style: import java.time types in TimestampUtils #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow, that seems obvious.. strange that ever got in. |
|
I think the code did originally not use imports for these types because we had to generate Java 6 and Java 7 sources. However now that master is Java 8 only we can use these imports. The line break changes are because of the "Format edited lines" save action in Eclipse. The change only introduces normal imports, not static imports. |
|
can you turn that off ? I'd prefer to not see line formatting changes. If not it's probably fine too. |
|
Sure, no problem, I'll do the change with no newline changes. |
Use imports for java.time types in TimestampUtils.
marschall
force-pushed
the
TimestampUtils-java-time-imports
branch
from
b1363d1
to
11b72ca
Compare
marschall
added a commit
to marschall/pgjdbc
that referenced
this pull request
Dec 31, 2021
Use imports for java.time types in all remaining classes. Follow up for pgjdbc#2380
2 tasks
davecramer
pushed a commit
that referenced
this pull request
Dec 31, 2021
Use imports for java.time types in all remaining classes. Follow up for #2380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use imports for java.time types in TimestampUtils.
All Submissions: