Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: Use jre utf-8 decoding #2317

Merged
merged 3 commits into from
Oct 22, 2021
Merged

improv: Use jre utf-8 decoding #2317

merged 3 commits into from
Oct 22, 2021

Conversation

bokken
Copy link
Member

@bokken bokken commented Oct 21, 2021

Remove use of custom utf-8 decoding as the jre implementation is nearly always faster in jdk 11+. Additionally, improvements continue to be made in the jdk.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew autostyleCheck checkstyleAll pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain. Invalid utf-8 will no longer result in failure, but rather use of unicode replacement char.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Remove use of custom utf-8 decoding.
remove unused imports
@bokken bokken merged commit a578603 into pgjdbc:master Oct 22, 2021
@bokken bokken deleted the java-utf8 branch October 22, 2021 17:30
bokken added a commit to bokken/pgjdbc that referenced this pull request Oct 29, 2021
I missed removing the base OptimizedUTF8Encoder class as part of
pgjdbc#2317
bokken added a commit that referenced this pull request Oct 29, 2021
I missed removing the base OptimizedUTF8Encoder class as part of
#2317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant