Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EscapeSyntaxCallModeCallTest failure with PG14 #2267

Closed
jchampio opened this issue Sep 27, 2021 · 4 comments
Closed

EscapeSyntaxCallModeCallTest failure with PG14 #2267

jchampio opened this issue Sep 27, 2021 · 4 comments

Comments

@jchampio
Copy link

Hello,

We're seeing a test failure when building against the REL_14_STABLE branch of Postgres:

FAILURE   0.1sec, org.postgresql.test.jdbc3.EscapeSyntaxCallModeCallTest > testInvokeFunctionHavingReturnParameter
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.postgresql.test.jdbc3.EscapeSyntaxCallModeCallTest.testInvokeFunctionHavingReturnParameter(EscapeSyntaxCallModeCallTest.java:63)

From a quick skim of the other issues, it seems like this might be related to #2190? This is a cloud build, so my ability to hop on and debug is somewhat limited; I'm hoping it's a simple reproduction for others.

Driver Version?

42.2.24

Java Version?

openjdk version "1.8.0_302"
OpenJDK Runtime Environment (build 1.8.0_302-b08)
OpenJDK 64-Bit Server VM (build 25.302-b08, mixed mode)

OS Version?

CentOS 7

PostgreSQL Version?

REL_14_STABLE (as of September 24, 2021)

@davecramer
Copy link
Member

Thx, have been able to reproduce this. PR#2190 should have been backpatched...

@jchampio
Copy link
Author

Just in case it helps: switching to a different matcher gives more information (disregard line numbers since they have changed):

FAILURE   0.0sec, org.postgresql.test.jdbc3.EscapeSyntaxCallModeCallTest > testInvokeFunctionHavingReturnParameter
    java.lang.AssertionError: 
    Expected: a string equal to "42809" ignoring case
         but: was "42883"
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.postgresql.test.jdbc3.EscapeSyntaxCallModeCallTest.testInvokeFunctionHavingReturnParameter(EscapeSyntaxCallModeCallTest.java:66)

@davecramer
Copy link
Member

thx, ya that is it

davecramer added a commit to davecramer/pgjdbc that referenced this issue Sep 27, 2021
…tInvokeFunctionHavingReturnParameter, also add v13, and v14 to Server versions
davecramer added a commit that referenced this issue Nov 15, 2021
…eFunctionHavingReturnParameter, also add v13, and v14 to Server versions (#2268)
@davecramer
Copy link
Member

closed with 51c70a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants