Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: Arrays in Object[] #2230

Merged
merged 4 commits into from
Oct 21, 2021
Merged

improv: Arrays in Object[] #2230

merged 4 commits into from
Oct 21, 2021

Conversation

bokken
Copy link
Member

@bokken bokken commented Aug 20, 2021

Support an Object[] which contains other arrays as a multi-dimensional array.

#2226

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Does ./gradlew autostyleCheck checkstyleAll pass ?
  3. Have you added your new test classes to an existing test suite in alphabetical order?

Changes to Existing Features:

  • Does this break existing behaviour? If so please explain.
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

bokken and others added 3 commits August 20, 2021 08:17
when an Object[] contains other arrays, treat as though it were a
multi-dimensional array
the one exception is byte[], which is not supported.
@hashhar
Copy link

hashhar commented Sep 21, 2021

@bokken @davecramer Anything I can help with to eventually make this in?

@bokken
Copy link
Member Author

bokken commented Sep 21, 2021

We will have a release here pretty soon which drops support for jre 6 and 7.
I will merge this in after that.

@wendigo
Copy link

wendigo commented Sep 23, 2021

@bokken that's a great news! Thanks

@hashhar
Copy link

hashhar commented Oct 20, 2021

@bokken I see that 42.3.0 was just cut and removed support for JRE 6 and 7. Does this mean this PR is now unblocked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants