test: materialized view privileges #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add to TestUtil and also to DatabaseMetaData setup and teardown fixes pgjdbc#2060
make "matviewtest" all lowercase so it can be found in pg catalog, which lowercases all names fixes pgjdbc#2060
Remove reused code Add comments
…gjdbc into tests_for_getTablePrivileges
sehrope
requested changes
Jul 6, 2021
| Statement st = con.createStatement(); | ||
| try { | ||
| // Drop the view | ||
| dropView(con, matViewName); |
There was a problem hiding this comment.
This should be dropMaterializedView(...).
| @@ -73,7 +73,6 @@ public void setUp() throws Exception { | |||
| } | |||
| TestUtil.createTable(con, "metadatatest", | |||
| "id int4, name text, updated timestamptz, colour text, quest text"); | |||
| TestUtil.createTable(con, "precision_test", "implicit_precision numeric"); | |||
There was a problem hiding this comment.
I think you might be basing this on an out of date branch. Rebase atop master as these changes should not be removing those tests.
pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
Outdated
Show resolved
Hide resolved
pgjdbc/src/test/java/org/postgresql/test/jdbc2/DatabaseMetaDataTest.java
Show resolved
Hide resolved
|
I did a quick review of this PR. Some changes requested. I also enabled the CI to build. You should be able to run all of this locally too. |
|
@mgrobaker I would love to merge this but we need some changes made. Are you able to take care of this ? |
|
@davecramer thank you for finishing this for me - sorry I hadn't responded to the original review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2060