Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getProcedures, getFunctions should find all procedures/functions if schema is null #2173

Closed
davecramer opened this issue Jun 7, 2021 · 4 comments · Fixed by #2174
Closed

getProcedures, getFunctions should find all procedures/functions if schema is null #2173

davecramer opened this issue Jun 7, 2021 · 4 comments · Fixed by #2174

Comments

@davecramer
Copy link
Member

The spec says that getFunctions/getProcedures should not be limited to the current schema if schema is null

Currently we limit it to the search_path
@davecramer
Copy link
Member Author

Squirrel related issue https://sourceforge.net/p/squirrel-sql/bugs/1416/

@sehrope
Copy link
Member

sehrope commented Jun 7, 2021

I have a branch that fixes this. The fix itself is just removing those two filters so the bulk of it is updating the tests to reflect the change in behavior. Once it cycles through CI I'll open a PR for it.

@davecramer
Copy link
Member Author

OK, I was going to create a PR but I'll leave it for you

@davecramer
Copy link
Member Author

Looks like the tests need a fair bit of work.

@sehrope sehrope mentioned this issue Jun 7, 2021
Merged
8 tasks
@sync-by-unito sync-by-unito bot mentioned this issue Jun 11, 2021
Merged
@sync-by-unito sync-by-unito bot mentioned this issue Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix metadata functions getProcedures() and getFunctions() to ignore search_path sehrope/pgjdbc
2 participants
@davecramer @sehrope