New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false #2148
Conversation
PR for #2147 |
Thank you very much for the PR. https://github.com/pgjdbc/pgjdbc/blob/master/docs/documentation/head/connect.md will require an entry as well. Thanks |
I'll take a look at this for review. We should add a test for this as well. |
pgjdbc/src/main/java/org/postgresql/jdbc/BatchResultHandler.java
Outdated
Show resolved
Hide resolved
Updated after codereview |
I've rebased this, cleaned up a few things, and added a test. I'm going to try pushing it to your branch to see if that actually works. |
Nice looks like the push worked. Let's see it run through CI and then we'll merge it. I split out your original fix into two commits. The first updates the docs. The second is the fix for the property handling with batches. The fix itself worked but was missing an update to the one other test class that also implements BaseConnection and there were a couple style issues. Third commit adds some new tests with batching. |
This is ready to go but let's wait for #2152 so that the CHANGELOG entry can be corrected as well. |
This has been merged. Thanks for the bug report and PR. |
No description provided.