Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false #2148

Merged
merged 3 commits into from May 15, 2021
Merged

Avoid leaking server error details through BatchUpdateException when logServerErrorDetail=false #2148

merged 3 commits into from May 15, 2021

Conversation

frode-carlsen
Copy link
Contributor

No description provided.

@frode-carlsen
Copy link
Contributor Author

PR for #2147

@davecramer
Copy link
Member

Thank you very much for the PR.

https://github.com/pgjdbc/pgjdbc/blob/master/docs/documentation/head/connect.md will require an entry as well.
Additionally can you add an entry into CHANGELOG.md?

Thanks

@sehrope
Copy link
Member

sehrope commented May 12, 2021

I'll take a look at this for review. We should add a test for this as well.

@frode-carlsen
Copy link
Contributor Author

Updated after codereview

@sehrope
Copy link
Member

sehrope commented May 13, 2021

I've rebased this, cleaned up a few things, and added a test. I'm going to try pushing it to your branch to see if that actually works.

@sehrope
Copy link
Member

sehrope commented May 13, 2021

Nice looks like the push worked. Let's see it run through CI and then we'll merge it.

I split out your original fix into two commits. The first updates the docs. The second is the fix for the property handling with batches. The fix itself worked but was missing an update to the one other test class that also implements BaseConnection and there were a couple style issues.

Third commit adds some new tests with batching.

@sehrope
Copy link
Member

sehrope commented May 13, 2021

This is ready to go but let's wait for #2152 so that the CHANGELOG entry can be corrected as well.

@sehrope sehrope merged commit 8b6afc0 into pgjdbc:master May 15, 2021
@sehrope
Copy link
Member

sehrope commented May 15, 2021

This has been merged. Thanks for the bug report and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants