Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog, bump version number #2126

Merged
merged 7 commits into from Apr 22, 2021

Conversation

davecramer
Copy link
Member

No description provided.

@sehrope
Copy link
Member

sehrope commented Apr 16, 2021

Why is the entire contributions.json being rewritten in the diff? Whitespace?

Also, the inline non-ASCII letters are being replaced with \u... escape sequences. Not sure if that's intentional either.

@davecramer
Copy link
Member Author

Using a new tool to do this, there may be some issues.

@davecramer
Copy link
Member Author

better question is why are the login tests failing

@sehrope
Copy link
Member

sehrope commented Apr 16, 2021

The line in question creates a server socket on a random port:

this.listenSocket = new ServerSocket(0, 1, localAddr);

Error says it's related to binding the server socket:

java.net.BindException: Cannot assign requested address (Bind failed)
    at java.net.AbstractPlainSocketImpl.bind(AbstractPlainSocketImpl.java:387)
    at java.net.ServerSocket.bind(ServerSocket.java:392)
    at java.net.ServerSocket.<init>(ServerSocket.java:254)
    at org.postgresql.test.jdbc2.LoginTimeoutTest$TimeoutHelper.<init>(LoginTimeoutTest.java:97)
    at org.postgresql.test.jdbc2.LoginTimeoutTest.testTimeoutOccurs(LoginTimeoutTest.java:137)

I bet this is GitHub Action / Docker related. Sounds similar to this: OpenLEADR/openleadr-python#30

Maybe they changed something in how networking presents itself that it's manifesting now.

@davecramer
Copy link
Member Author

@davecramer davecramer closed this Apr 16, 2021
@davecramer davecramer reopened this Apr 16, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@davecramer
Copy link
Member Author

so it seems github actions are broken for now. any reason not to push this and release ?

@davecramer davecramer merged commit 1a15d6e into pgjdbc:release/42.2 Apr 22, 2021
@davecramer davecramer deleted the prepare42.2.20 branch April 22, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants