Autosave causes out of shared memory errors in batch processing

[junixar]

I'm submitting a bug that occurs by using of save points and batch processing

• bug report
• feature request

Describe the issue
Analog to the issue #1407 , if AutoSave.ALWAYS is set, the save points are not released after executing of batch, which causes "out of shared memory" errors after a greater number of batches have been executed.

Driver Version?
42.2.6

Java Version?
1.8.0_221

OS Version?
Debian GNU/Linux 9

PostgreSQL Version?
PostgreSQL 11.5

To Reproduce
Steps to reproduce the behaviour:

Expected behaviour
The following code demonstrates the problem. With default settings the test runs on my machine for about 12000 iterations before the error is thrown. If the "cleanup" is activated is runs through just fine.

  @Test
  public void testPgsqlJdbcSavepointWithBatchProcessing() throws Exception {
    Properties props = new Properties();
    props.setProperty("username", "postgres");
    props.setProperty("_test_database", "postgres");
    props.setProperty("cleanupSavepoints", "true");

    Connection conn = TestUtil.openDB(props);

    BaseConnection baseConnection = conn.unwrap(BaseConnection.class);
    baseConnection.setAutosave(AutoSave.ALWAYS);
    baseConnection.setAutoCommit(false);

    TestUtil.createTable(conn, "rollbacktest", "a int, str text");

    int iterations = 20000;
    boolean cleanup = false;

    PreparedStatement statement = conn.prepareStatement("insert into rollbacktest(a, str) values (?, ?)");
    for (int i = 0; i < iterations; i++) {
      long startTime = System.nanoTime();

      statement.setInt(1, i);
      statement.setString(2, UUID.randomUUID().toString());
      statement.addBatch();
      statement.executeBatch();

      long timeElapsed = System.nanoTime() - startTime;

      System.out.println(i + "/" + iterations + " took " + timeElapsed / 1000000 + "ms ");

      if (cleanup) {
        baseConnection.setAutosave(AutoSave.NEVER);

        Statement releaseStatement = conn.createStatement();
        releaseStatement.executeUpdate("release savepoint PGJDBC_AUTOSAVE");
        releaseStatement.close();

        baseConnection.setAutosave(AutoSave.ALWAYS);
      }
    }
    statement.close();
  }

[bokken]

I think this was fixed here: #1409

[junixar]

In #1409 it was fixed only for executeQuery with single statement, but not for batch executions. This is the point in this new issue.

[tbrodbeck-adc]

I can confirm that, too.

[tbrodbeck-adc]

Thanks :-)

[davecramer]

fixed in #1583