Providing types for plpgsql function signature

[jsommr]

"UNKNOWN" is currently returned for all types in a plpgsql function signature because of this:

libpg_query/src/pg_query_parse_plpgsql.c

Line 193 in d1d0186

argdtype = plpgsql_build_datatype(UNKNOWNOID, -1, InvalidOid, NULL);

Which calls a mocked function:

libpg_query/scripts/extract_source.rb

Line 470 in e9e4ba9

runner.mock('plpgsql_build_datatype', 'PLpgSQL_type * plpgsql_build_datatype(Oid typeOid, int32 typmod, Oid collation, TypeName *origtypname) { PLpgSQL_type *typ; typ = (PLpgSQL_type *) palloc0(sizeof(PLpgSQL_type)); typ->typname = pstrdup("UNKNOWN"); typ->ttype = PLPGSQL_TTYPE_SCALAR; return typ; }')

We see that UNKNOWN is hardcoded because of typ->typname = pstrdup("UNKNOWN");.

It is quite easy to change plpgsql_build_datatype into something that returns a PLpgSQL_type where typname is populated with a given type. Say we have create function test(x customtype, y int) ..... For x the type will be customtype, while it will be pg_catalog.int4 for y because of the way the parser works. Question: Is that the reason this isn't implemented - that built in types are turned into something else for function signatures, while simply being provided as-is from the DECLARE section?

I can't figure out what ideally should be returned here. We do get the original location of the type in the function signature, and can use that to extract the actual written type, like int instead of pg_catalog.int4. It's not super straight forward with signatures like create function complicated(x character(100), y time with time zone default '...', z "mySchema" . sometype[]) etc., but not knowing what would be the right thing to use here, I'd rather ask if some thought have gone into this, or what opinions you have?