Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Python 3.10 eventlet==0.31.0 breaking the application (RM #7006) #4766

Closed
dpage opened this issue Nov 17, 2021 · 9 comments
Closed

With Python 3.10 eventlet==0.31.0 breaking the application (RM #7006) #4766

dpage opened this issue Nov 17, 2021 · 9 comments

Comments

@dpage
Copy link
Contributor

dpage commented Nov 17, 2021

Issue migrated from Redmine: https://redmine.postgresql.org/issues/7006
Originally created by Rahul Shirsat at 2021-11-17 08:28:51 UTC.

When trying with Python 3.10 with eventlet 0.31.0, it breaks with -


Traceback (most recent call last):
  File "", line 1, in 
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/__init__.py", line 17, in 
    from eventlet import convenience
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/convenience.py", line 7, in 
    from eventlet.green import socket
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/green/socket.py", line 4, in 
    __import__('eventlet.green._socket_nodns')
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/green/_socket_nodns.py", line 11, in 
    from eventlet import greenio
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/greenio/__init__.py", line 3, in 
    from eventlet.greenio.base import *  # noqa
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/greenio/base.py", line 32, in 
    socket_timeout = eventlet.timeout.wrap_is_timeout(socket.timeout)
  File "/data/data/com.termux/files/usr/lib/python3.10/site-packages/eventlet/timeout.py", line 166, in wrap_is_timeout
    base.is_timeout = property(lambda _: True)
TypeError: cannot set 'is_timeout' attribute of immutable type 'TimeoutError'

Above issue is fixed in the eventlet/eventlet#715.

Work around was done trying with eventlet master dependency -

And then with -

  • git+git://github.com/eventlet/eventlet.git@15d3c24

With the latest commit id 15d3c24 pgAdmin wheel is failing.

Approaches to solve -

  1. Need to find a way to apply commit id appropriately for pgadmin wheel to generate successfully.
  2. Directly use the latest release version of eventlet (not yet released)
@dpage
Copy link
Contributor Author

dpage commented Nov 17, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-1
Originally created by Rahul Shirsat at 2021-11-17 08:33:18 UTC.

Redmine ticket header update:

Name Old Value New Value
Status changed New In Progress

@dpage
Copy link
Contributor Author

dpage commented Nov 17, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-2
Originally created by Rahul Shirsat at 2021-11-17 13:24:01 UTC.

New eventlet dependency is out (v0.33.0) and used to resolve the issue.

PIP wheel build is resolved for Python 3.10 when using eventlet v0.33.0

  • PIP wheel created with no issues on Python 3.10

Overall other basic testing includes -

  1. PSQL
  2. Query tool
  3. Server mode internal login

Tested on various python versions -

  1. 3.10.0
  2. 3.7.12
  3. 3.8.12
  4. 3.9.7

OS involved in testing -
MacOS Big Sur v11.0.1

No issues found so far with above scenarios.

Patch sent!

Redmine ticket header update:

Name Old Value New Value
Start Date changed 2021-11-17 2021-11-15

@dpage
Copy link
Contributor Author

dpage commented Nov 18, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-3
Originally created by Rahul Shirsat at 2021-11-18 07:07:14 UTC.

Applied in changeset commit:5b99646798a58be2c5edbc7ad5440498e6c01efa.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 0 90
Status changed In Progress In Testing

@dpage
Copy link
Contributor Author

dpage commented Nov 18, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-4
Originally created by Akshay Joshi at 2021-11-18 07:08:29 UTC.

Redmine ticket header update:

Name Old Value New Value
Fixed Version changed 6.3

@dpage
Copy link
Contributor Author

dpage commented Nov 24, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-5
Originally created by Akshay Joshi at 2021-11-24 10:35:22 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 104 EDB Sprint 105

@dpage
Copy link
Contributor Author

dpage commented Dec 1, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-6
Originally created by Fahar Abbas at 2021-12-01 06:45:07 UTC.

Redmine ticket header update:

Name Old Value New Value
Assigned To changed Rahul Shirsat Fahar Abbas

@dpage
Copy link
Contributor Author

dpage commented Dec 8, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-7
Originally created by Akshay Joshi at 2021-12-08 10:34:40 UTC.

Redmine ticket header update:

Name Old Value New Value
Sprint changed EDB Sprint 105 EDB Sprint 106

@dpage
Copy link
Contributor Author

dpage commented Dec 16, 2021

Comment migrated from Redmine: https://redmine.postgresql.org/issues/7006#note-8
Originally created by Fahar Abbas at 2021-12-16 11:01:38 UTC.

This is resolved in the candidate build for 6.3 Release.

Redmine ticket header update:

Name Old Value New Value
Done Ratio changed 90 100
Status changed In Testing Resolved

@dpage
Copy link
Contributor Author

dpage commented Sep 15, 2022

Issue closed on Redmine.

@dpage dpage closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant