Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling Errors and Node.js Version Bump #848

Open
beingforthebenefit opened this issue Jun 30, 2023 · 1 comment
Open

Spelling Errors and Node.js Version Bump #848

beingforthebenefit opened this issue Jun 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@beingforthebenefit
Copy link

beingforthebenefit commented Jun 30, 2023

Describe the bug
The nodejs version needs to be updated since the build fails (and there are spelling errors in the Dockerfile).

The old nodejs version failed to build because it was incompatible with the Alpine repository. In the Dockerfile, the specific version of nodejs used was 16.16.0-r0. However, during the package installation step, when running apk add --no-cache nodejs=16.16.0-r0, the package manager was unable to find and select the required version of nodejs from the repository. This should be bumped to 16.20.1-r0

This failure occurred because the Alpine repository might not have contained the exact version 16.16.0-r0 of nodejs.

To Reproduce

  1. Clone the repository.
  2. Checkout the new-ui branch with the Dockerfile.
  3. Build the Docker image using the command docker build . -t petio.

Expected behavior
The Docker image should be built successfully without any spelling errors, and the nodejs version should be updated to the desired version.

Screenshots
image

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
The spelling errors in the Dockerfile need to be corrected, and the nodejs version should be bumped to a compatible version to avoid conflicts with the Alpine repository. This will ensure a smooth build process and proper functioning of the application within the Docker container.

@beingforthebenefit beingforthebenefit added the bug Something isn't working label Jun 30, 2023
@ADRFranklin
Copy link
Collaborator

You should checkout the docker image in the dev branch it's more up to date then the new-ui branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants