From 5a8ae5d56f8218afe30b579b68db018218e133cc Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Tue, 4 May 2021 14:39:41 -0400 Subject: [PATCH] Weird test failures related to puppeteer (#3696) * Weird test failures related to puppeteer Fixes #3694 * tell dependabot to not upgrade puppeteer 9.x automatically * specific about 9.1.x --- .github/dependabot.yml | 9 +++++++++ package.json | 2 +- yarn.lock | 8 ++++---- 3 files changed, 14 insertions(+), 5 deletions(-) diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 54793e658861..d1a705fa9120 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -40,3 +40,12 @@ updates: prefix: build prefix-development: chore include: scope + + ignore: + # In https://github.com/mdn/yari/issues/3694 we discovered that + # installing puppeteer 9.1.0 seems to have made the tests flaky + # when jest starts up. See the issue for more detail. + # After this, we can keep an eye on puppeteer to see if the tests + # get better later with new versions. + - dependency-name: "puppeteer" + versions: ["9.1.x"] diff --git a/package.json b/package.json index 5b801dc8a891..9bec2c9d6d03 100644 --- a/package.json +++ b/package.json @@ -144,7 +144,7 @@ "prettier": "2.2.1", "prettier-plugin-packagejson": "^2.2.10", "pretty-quick": "3.1.0", - "puppeteer": "9.1.0", + "puppeteer": "9.0.0", "react": "17.0.2", "react-dom": "17.0.2", "react-is": "^17.0.2", diff --git a/yarn.lock b/yarn.lock index 4585dd3b12e7..f5d93eb080b4 100644 --- a/yarn.lock +++ b/yarn.lock @@ -15978,10 +15978,10 @@ pupa@^2.0.1: dependencies: escape-goat "^2.0.0" -puppeteer@9.1.0: - version "9.1.0" - resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-9.1.0.tgz#0530ed1f595088eefd078c8f1f7618d00f216a56" - integrity sha512-+BWwEKYQ9oBTUcDYwfgnVPlHSEYqD4sXsMqQf70vSlTE6YIuXujc7zKgO3FyZNJYVrdrUppy/LLwGF1IRacQMQ== +puppeteer@9.0.0: + version "9.0.0" + resolved "https://registry.yarnpkg.com/puppeteer/-/puppeteer-9.0.0.tgz#b476e17ceb3e33a6667bf682d66dde9898f9c031" + integrity sha512-Avu8SKWQRC1JKNMgfpH7d4KzzHOL/A65jRYrjNU46hxnOYGwqe4zZp/JW8qulaH0Pnbm5qyO3EbSKvqBUlfvkg== dependencies: debug "^4.1.0" devtools-protocol "0.0.869402"