Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the node_id to the available output #299

Merged
merged 1 commit into from Apr 2, 2024
Merged

Add the node_id to the available output #299

merged 1 commit into from Apr 2, 2024

Conversation

amonshiz
Copy link
Contributor

I would like to use this action to find comments for minimization but that seems to require using the GraphQL API. The GraphQL API requires the node_id for the minimizeComment and unminimizeComment mutations. Thankfully the REST API returns the GraphQL node_id property and as long as this passes it back we can then use it in GraphQL mutations!

I updated the action defintion, the declared shape of a Comment, and all the tests (both in ts and in the workflow).

peter-evans
peter-evans approved these changes Apr 2, 2024
View reviewed changes
Copy link
Owner

@peter-evans peter-evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! LGTM

@peter-evans peter-evans merged commit 2e93ece into peter-evans:main Apr 2, 2024
5 checks passed
peter-evans pushed a commit that referenced this pull request Apr 2, 2024
@amonshiz @peter-evans
feat: add the node_id to the available output (#299)
3eae4d3
@amonshiz
Copy link
Contributor Author

amonshiz commented Apr 3, 2024

Thank you for accepting and sorry about missing the documentation!

@amonshiz amonshiz deleted the amonshiz/add-node-id branch April 3, 2024 19:09
@peter-evans
Copy link
Owner

No problem. Thank you! This was much more complete and tested than most contributions I receive. Appreciate it.

github-merge-queue bot pushed a commit to 4m-mazi/gh-test that referenced this pull request May 11, 2024
@mazi-renovate
ci(deps): update peter-evans/find-comment action from v3.0.0 to v3.1.0 (
d814300 
#730)

This PR contains the following updates:

| Package | Type | Update | Change | OpenSSF |
|---|---|---|---|---|
|
[peter-evans/find-comment](https://togithub.com/peter-evans/find-comment)
| action | minor | `v3.0.0` -> `v3.1.0` | [![OpenSSF
Scorecard](https://api.securityscorecards.dev/projects/github.com/peter-evans/find-comment/badge)](https://securityscorecards.dev/viewer/?uri=github.com/peter-evans/find-comment)
|

---

### Release Notes

<details>
<summary>peter-evans/find-comment (peter-evans/find-comment)</summary>

###
[`v3.1.0`](https://togithub.com/peter-evans/find-comment/releases/tag/v3.1.0)

[Compare
Source](https://togithub.com/peter-evans/find-comment/compare/v3.0.0...v3.1.0)

##### What's Changed

- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.8 to
18.19.10 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#283
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.10 to
18.19.14 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#284
- build(deps): bump peter-evans/create-pull-request from 5 to 6 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#285
- build(deps): bump peter-evans/slash-command-dispatch from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#286
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.14 to
18.19.15 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#287
- build(deps-dev): bump prettier from 3.2.4 to 3.2.5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#288
- build(deps-dev): bump eslint-plugin-jest from 27.6.3 to 27.9.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#289
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.15 to
18.19.17 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#290
- build(deps-dev): bump eslint from 8.56.0 to 8.57.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#291
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.17 to
18.19.18 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#292
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.18 to
18.19.21 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#293
- build(deps-dev): bump eslint-plugin-github from 4.10.1 to 4.10.2 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#294
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.21 to
18.19.22 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#295
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.22 to
18.19.24 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#297
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.24 to
18.19.26 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#298
- build(deps-dev): bump
[@&#8203;types/node](https://togithub.com/types/node) from 18.19.26 to
18.19.28 by [@&#8203;dependabot](https://togithub.com/dependabot) in
[peter-evans/find-comment#300
- feat: add the node_id to the available output by
[@&#8203;amonshiz](https://togithub.com/amonshiz) in
[peter-evans/find-comment#299

##### New Contributors

- [@&#8203;amonshiz](https://togithub.com/amonshiz) made their first
contribution in
[peter-evans/find-comment#299

**Full Changelog**:
peter-evans/find-comment@v3.0.0...v3.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJzZW12ZXI6bm9uZSJdfQ==-->

Co-authored-by: mazi-renovate[bot] <161091290+mazi-renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-evans peter-evans peter-evans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amonshiz @peter-evans