Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update to use node20 #281

Merged
merged 1 commit into from Jan 25, 2024

Conversation

mmaetzler
Copy link
Contributor

@mmaetzler mmaetzler commented Jan 24, 2024

Not sure what the contribution rules are, but here I go :D

This PR attempts to fix #280
It updates the runner to use node20 and also adds an engine definition to force node20.

Code builds and jest tests pass (locally)

@mmaetzler mmaetzler marked this pull request as draft January 24, 2024 19:35
@mmaetzler mmaetzler marked this pull request as ready for review January 24, 2024 19:39
@peter-evans peter-evans changed the base branch from main to node20 January 25, 2024 11:02
@peter-evans peter-evans merged commit fabc6b5 into peter-evans:node20 Jan 25, 2024
5 checks passed
@peter-evans
Copy link
Owner

Thank you. I'm planning to update all my actions in the coming week.

peter-evans added a commit that referenced this pull request Jan 25, 2024
* fix: update to use node20 (#281)

* build: bump package version

---------

Co-authored-by: Marco Maetzler <105300787+mmaetzler@users.noreply.github.com>
@mmaetzler
Copy link
Contributor Author

Thanks! I'm using your actions a lot (thanks a ton for creating them!), so I'm happy to open up PRs if you want me to in the other action repos as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH warning: Node.js 16 actions are deprecated
2 participants