Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow nth as a config input #164

Merged
merged 4 commits into from Apr 25, 2023
Merged

feat: allow nth as a config input #164

merged 4 commits into from Apr 25, 2023

Conversation

NiloCK
Copy link
Contributor

@NiloCK NiloCK commented Apr 21, 2023

PR is stacked on #163.

New feature is not under test. Similar to first / last, testing would require a bigger refactor of the findComment function, so that mocked collections of comments can be processed under test.

@NiloCK NiloCK marked this pull request as ready for review April 21, 2023 13:51
@peter-evans
Copy link
Owner

@NiloCK Thank you for this contribution!

I'm going to merge to a dev branch first so I can make a few additions, then I'll merge to main.

@peter-evans peter-evans changed the base branch from main to dev April 25, 2023 03:04
@peter-evans peter-evans merged commit e3ce6a8 into peter-evans:dev Apr 25, 2023
1 check passed
peter-evans added a commit that referenced this pull request Apr 25, 2023
* feat: allow `nth` as a config input (#164)

* refactor: remove dup implementation for first/last

* remove `;` for linter

* feat: add `nth` input config

---------

Co-authored-by: Peter Evans <18365890+peter-evans@users.noreply.github.com>

* minor refactor and tests

* update readme

* ci test

---------

Co-authored-by: Colin Kennedy <NiloCK@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nth comment match
2 participants