Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Pull Request does not work when repository name ends in Xgit #1256

Closed
campersau opened this issue Sep 22, 2022 · 1 comment · Fixed by #1257
Closed

Create Pull Request does not work when repository name ends in Xgit #1256

campersau opened this issue Sep 22, 2022 · 1 comment · Fixed by #1257

Comments

@campersau
Copy link
Contributor

campersau commented Sep 22, 2022

Subject of the issue

We have a reprository named "ungit" https://github.com/FredrikNoren/ungit and after updating the create-pull-request action to v4 it does not work anymore and reports "Error: Not Found". See https://github.com/campersau/ungit/actions/runs/3103556378/jobs/5027017692#step:7:111

I think the issue is that in #1153 the .git suffix is ignored, but the regex is wrong as it does not escape the ..

Steps to reproduce

Use the create-pull-request action with a repository which name ends in Xgit


I added some more logging in my own fork and you can see that the "ngit" suffix is missing:

Attempting creation of pull request {
    "owner": "campersau",
    "repo": "u", // <---------------- missing "ngit"
    "title": "Bump Dependencies",
    "head": "campersau:bumpdependencies",
    "base": "master",
    "body": "...",
    "draft": false
  }
@peter-evans
Copy link
Owner

Thank you for fixing this!

Released as v4.1.3 / v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants