New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GA quote/ref in concepts-guidelines.md #1169
Conversation
The current quote and reference link appear to be out of date
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for spotting this!
I just have one suggestion to change the link, but otherwise looks good to me. 👍
docs/concepts-guidelines.md
Outdated
|
||
[GitHub Actions: Events that trigger workflows](https://docs.github.com/en/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token) | ||
|
||
[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be a slightly more relevant link. It's the same paragraph, but just a different page that is more focused around triggering workflows from runs.
[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow) | |
[GitHub Actions: Automatic token authentication](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#triggering-a-workflow-from-a-workflow) |
I see, the two links (the one I used and the one you suggested) have similar text. I updated it to reference the link you suggested and also quote the exact text from that link (which itself contains a link that redirects to the link I had found). Does that look right? |
Thanks! |
* Update GA quote/ref in concepts-guidelines.md The current quote and reference link appear to be out of date * Change "Triggering further workflow runs" excerpt
Stumbled upon this when reading the documentation. The current quote and reference link appear to be out of date.