Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid panic when a coordinate is NaN #32

Merged
merged 1 commit into from Aug 22, 2020
Merged

Avoid panic when a coordinate is NaN #32

merged 1 commit into from Aug 22, 2020

Conversation

msk
Copy link
Member

@msk msk commented Aug 21, 2020

No longer panics when a coordinate is NaN; the distance from a point with
NaN in its coordinate and another point is considered greater than the
distance between any two points without NaN in their coordinates.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #32 into master will increase coverage by 0.27%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   92.36%   92.63%   +0.27%     
==========================================
  Files           3        3              
  Lines         419      421       +2     
==========================================
+ Hits          387      390       +3     
+ Misses         32       31       -1     
Impacted Files Coverage Δ
src/ball_tree.rs 93.71% <83.33%> (+0.03%) ⬆️
src/vantage_point_tree.rs 87.17% <100.00%> (+1.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e96f2...f9aa094. Read the comment docs.

@minshao minshao merged commit 77a89cf into master Aug 22, 2020
@minshao minshao deleted the ordered-float branch August 22, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants