Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing expectation: expectWarning()? #1102

Open
withinboredom opened this issue Feb 25, 2024 · 0 comments
Open

Missing expectation: expectWarning()? #1102

withinboredom opened this issue Feb 25, 2024 · 0 comments

Comments

@withinboredom
Copy link

I see a nice yellow WARN:

image

But I'm explicitly expecting a warning here. My test covers this through error_get_last as a workaround; however, it would be nice to simply:

it('emits a warning', function() {
  trigger_error('warn', E_USER_WARNING);
})->expectWarningMessage('warn');

Similar to how exceptions can be checked.

I'd prefer to throw an exception in my library; however, that would be disastrous since nothing would break unless the library is used in a particular way. So, a warning is emitted so that the developer can either ignore it or choose to throw an exception if it effects them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant