Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giscus comments #251

Open
2 tasks done
bravo-kernel opened this issue Jan 30, 2023 · 5 comments · May be fixed by #267
Open
2 tasks done

Giscus comments #251

bravo-kernel opened this issue Jan 30, 2023 · 5 comments · May be fixed by #267
Labels
enhancement New feature or request

Comments

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jan 30, 2023

Checklist

  • Issue has a meaningful title
  • I have searched the existing issues. See issues

Summary of the request

We could consider adding Giscus comments (built on Github discussions) for pages:

  • Matches our audience
  • Upvotes, reactions, etc.
  • Easily moderated via github interface
  • Could lead to more interaction

Additional info:

Try it out here https://www.bravo-kernel.com/blog/2020/01/creating-a-scheduled-broken-links-checker-using-github-actions

Suggested section

None

@bravo-kernel bravo-kernel added the enhancement New feature or request label Jan 31, 2023
@bravo-kernel bravo-kernel changed the title Giscus comments [Feature Request]Giscus comments Jan 31, 2023
@bravo-kernel bravo-kernel changed the title [Feature Request]Giscus comments Giscus comments Jan 31, 2023
@fflaten
Copy link
Collaborator

fflaten commented Jan 31, 2023

Looks like a cool solution. Comments is a bit uncommon for docs-sites though, isn't it?

Off-topic: In your example, why does it look like you're talking to yourself? You mention someone else, but only your posts :)

@bravo-kernel
Copy link
Collaborator Author

I agree that it is a bit uncommon but I can imagine it making the hurdle to comment, ask, etc. much lower.

The reason you are seeing me talking to myself (online and in real-life now) is... that those comments were imported from Disqus (hover on a username).

@nohwnd
Copy link
Member

nohwnd commented May 2, 2023

Upvote on this, azdo has comments for wiki and it is very useful when the page becomes outdated and people post tips on how to actually do the thing the page describes.

@fflaten
Copy link
Collaborator

fflaten commented May 2, 2023

Sounds great 👍
@bravo-kernel still working good on your blog. No issues after the theme-fix? Removing spam etc also works fine?

Usually I'd say GitHub-only would limit a comment-solution, but as it's already required to make a docs-issue it's fine.

@bravo-kernel
Copy link
Collaborator Author

No issues at all and even though spam is non-existent, annoying responses can always be deleted in Github Discussions.

@fflaten fflaten linked a pull request May 3, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants