Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI use Rust 1.62.0 for fix rustyline 10.1.0 #[default] compile error. #770

Merged
merged 1 commit into from Jan 18, 2023
Merged

CI use Rust 1.62.0 for fix rustyline 10.1.0 #[default] compile error. #770

merged 1 commit into from Jan 18, 2023

Conversation

huacnlee
Copy link
Member

@huacnlee huacnlee commented Jan 18, 2023 •
edited

@huacnlee huacnlee requested a review from a team as a code owner January 18, 2023 06:24
@huacnlee huacnlee requested review from NoahTheDuke and removed request for a team January 18, 2023 06:24
tomtau
tomtau approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one alternative would be to fix rusty line to the previous version, but ok to bump to 1.62 (the MSVR is still checked for the pest crate)

@tomtau tomtau merged commit cc4fc93 into pest-parser:master Jan 18, 2023
@tomtau tomtau mentioned this pull request Jan 18, 2023
Merged
@huacnlee huacnlee deleted the fix-ci branch January 18, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@NoahTheDuke NoahTheDuke Awaiting requested review from NoahTheDuke NoahTheDuke is a code owner automatically assigned from pest-parser/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huacnlee @tomtau