Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restrict the factorizer case to only atomic and compoundatomic rules #766

Merged
merged 2 commits into from Jan 11, 2023

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jan 10, 2023

closes #762

the full fix would require a bigger overhaul / refactoring of the optimizer

…ules

closes pest-parser#762

the full fix would require a bigger overhaul / refactoring of the optimizer
@tomtau tomtau requested a review from a team as a code owner January 10, 2023 09:54
@tomtau tomtau requested review from NoahTheDuke and removed request for a team January 10, 2023 09:54
Copy link
Member

@NoahTheDuke NoahTheDuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good fix for the moment.

@tomtau tomtau merged commit 174aae8 into pest-parser:master Jan 11, 2023
@tomtau tomtau deleted the fix/factor branch January 11, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change between 2.1 and 2.4/2.5
2 participants