Add Unicode Script into built-in rules. #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this change to add `CJK`, `HAN`, `HANGUL`, `KATAKANA`, `HIRAGANA` to built-in rules. https://unicode.org/faq/han_cjk.html - Chinese - `HAN` - Japanese - `KATAKANA`, `HIRAGANA` - Korean - `HANGUL` So we can easy to to match the CJK chars.
…roperty_names. - will generate property names by use macro. - has been removed.
huacnlee
force-pushed
the
feat/built-in-CJK
branch
from
a2938fc
to
57dfab7
Compare
huacnlee
changed the title
… BY_NAME values by `ucd-generate` generated. And export all property names from Unicode (Script).
huacnlee
force-pushed
the
feat/built-in-CJK
branch
from
9be5b65
to
89504ed
Compare
tomtau
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Awesome work, thanks @huacnlee ! Just one observation about the static item that was public, but ok to merge it.
Do you also plan to update the docs: https://github.com/pest-parser/book/blob/master/src/grammars/built-ins.md#unicode-rules ?
huacnlee
force-pushed
the
feat/built-in-CJK
branch
from
3aa0bf9
to
3b6d1dc
Compare
|
Pest book updated: |
tomtau
reviewed
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this change to add Unicode (Script) to built-in rules.
https://unicode.org/standard/supported.html
Built-in rules is generated by the data from unicode.org, so we can give a correctly rule.
So we can easy to use them without care about the unicode range.
for example:
HANKATAKANA,HIRAGANAHANGULARABICUsage example
All addition rules from Unicode (Script)