Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #728

Merged
merged 2 commits into from Oct 31, 2022
Merged

Update README.md #728

merged 2 commits into from Oct 31, 2022

Conversation

carnoxen
Copy link
Contributor

Fix a pest example. ident rule is more evidently.

Fix a pest example. ```ident``` rule is more evidently.
@carnoxen carnoxen requested a review from a team as a code owner October 31, 2022 04:05
@carnoxen carnoxen requested review from tomtau and removed request for a team October 31, 2022 04:05
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the example!
I assume this tries to fix the following issue: #551 , is that correct ?

if the fix is done in that way, it'll prevent all identifiers to start with a digit, not only the first one... so perhaps that description:

(...) where the first identifier does not start with a digit:

should be updated to:

(...) where identifiers do not start with a digit:

fix Example description above the pest code
@carnoxen
Copy link
Contributor Author

Thank you for fixing the example! I assume this tries to fix the following issue: #551 , is that correct ?

Yes it is. And I fixed the above sentence.

@tomtau tomtau enabled auto-merge (squash) October 31, 2022 14:27
@tomtau tomtau merged commit edaef7f into pest-parser:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README.md and website example grammar doesn't handle leading digit for all idents in ident_list
2 participants