Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: better CI hygiene #705

Merged
merged 1 commit into from
Sep 10, 2022
Merged

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Aug 29, 2022

closes #655

@tomtau tomtau force-pushed the fix/ci-improvement branch from 8f3de84 to 26aaab0 Compare September 2, 2022 16:37
@tomtau tomtau marked this pull request as ready for review September 2, 2022 16:37
@tomtau tomtau requested a review from a team as a code owner September 2, 2022 16:37
@tomtau tomtau requested review from NoahTheDuke, a team and CAD97 and removed request for a team September 2, 2022 16:37
@tomtau
Copy link
Contributor Author

tomtau commented Sep 2, 2022

@CAD97 I tried to include checking for the items discussed on the issue:

  • cargo msrv could not run on a workspace, so I added the loop to check individual crates
  • for cargo hack, I assume checking the feature-powerset is the most relevant/useful here
  • cargo-semver-checks GH action had issues with a bootstrap, so I included a custom script; it's more for assisting manual checking right now, because currently, it reports two violations on pest_meta that Rule and Parser are no longer publicly accessible from "grammar.rs"... but that seems to be a false positive: they weren't publicly accessible in 2.1.x either.

@tomtau
Copy link
Contributor Author

tomtau commented Sep 10, 2022

I'm planning to do a quick point release (see #702 (comment) ), so will merge this now. @pest-parser/triage @CAD97 feel free to comment for follow ups for the CI changes though!

@tomtau tomtau merged commit af4f105 into pest-parser:master Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better CI hygiene follow-up
1 participant