Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to use the same Rust version used for the parser #36

Closed
Tartasprint opened this issue Apr 24, 2023 · 3 comments · Fixed by #37
Closed

Update examples to use the same Rust version used for the parser #36

Tartasprint opened this issue Apr 24, 2023 · 3 comments · Fixed by #37

Comments

@Tartasprint
Copy link
Contributor

In pest-parser/pest#715 the Rust edition was updated to the 2021 edition.
I imagine it could be a good thing to the same with the examples given in the book.

This is the first time I contribute to a project, I am not sure how to proceed. I forked this repository and made the changes to adress this issue on this branch. Now I think I should do a pull request, but since I'm not sure if those changes are wanted I prefered creating an issue. Please tell me if this the expected behaviour :D

@tomtau
Copy link
Contributor

tomtau commented Apr 30, 2023

@Tartasprint yes, feel free to go ahead to open a PR. Maybe pest versions could be bumped in those examples as well?

@Tartasprint
Copy link
Contributor Author

I can do that :)
Shouldn't I also update the rust-version field to be 1.59.0 according to this pull request ?

@tomtau
Copy link
Contributor

tomtau commented May 1, 2023

@Tartasprint no, as I mentioned, that was for cargo-msrv (https://foresterre.github.io/cargo-msrv/), not pest itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants