Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format and bump node version to pass auto test #12

Merged
merged 8 commits into from Dec 31, 2022
Merged

format and bump node version to pass auto test #12

merged 8 commits into from Dec 31, 2022

Conversation

bluet
Copy link
Contributor

@bluet bluet commented Dec 30, 2022 •
edited

Fix testing failures.

  1. This commit broken the format checks 446926d
  2. node < 14 is no longer supported.

@bluet
Copy link
Contributor Author

bluet commented Dec 30, 2022

I found the auto testing failed.
One is for node 10, the other is due to formatting https://github.com/perry-mitchell/ulidx/actions/runs/3807193500/jobs/6476651618
And this is for passing the formatting check.

(no clue how to fix the node 10 support, yet)

@bluet
Copy link
Contributor Author

bluet commented Dec 30, 2022

Node version < 14 is no longer supported by Node.js official. https://nodejs.dev/en/about/releases/
I've bumped the node versions to 14, 16, 18, and changed base version for formatting test to 18 as it's the current LTS/Stable version.

@bluet bluet changed the title format to pass prettier check format and bump node version to pass auto test Dec 30, 2022
@perry-mitchell perry-mitchell merged commit 726cd37 into perry-mitchell:main Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perry-mitchell perry-mitchell perry-mitchell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bluet @perry-mitchell