Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isValid(), fix security issues in dependency #11

Merged
merged 5 commits into from Dec 30, 2022

Conversation

bluet
Copy link
Contributor

@bluet bluet commented Dec 29, 2022

No description provided.

Copy link
Owner

@perry-mitchell perry-mitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small things. Thanks for this!

source/ulid.ts Outdated Show resolved Hide resolved
test/ulid.spec.js Outdated Show resolved Hide resolved
test/ulid.spec.js Show resolved Hide resolved
@bluet
Copy link
Contributor Author

bluet commented Dec 30, 2022

hi @perry-mitchell patches pushed 👍

hope I can use the new version of ulidx from npm instead of my local build hahaha

@perry-mitchell
Copy link
Owner

Thanks, I'll check this in a few hours.. but I suspect it'll be fine and I'll do a release then.

Cheers!

@perry-mitchell perry-mitchell merged commit 52de42c into perry-mitchell:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants