Git branch detection on Jenkins default is wrong (I think)

[samhatoum]

percy-js/src/environment.js

Line 160 in ed3d495

result = this._env.ghprbSourceBranch;

Looking at the line above, it seems that Percy is resorting to the PR builder plugin branch, however on master builds on Jenkins, the branch becomes HEAD.

I've found GIT_BRANCH to work better, however, that has an issue that it reports origin/master and Percy uses master for baseline snapshots. I couldn't find anywhere to change the baseline branch so I ended up writing this script:

#!/usr/bin/env node
const cli = require('@percy-io/percy-storybook/lib/cli');

process.env.PERCY_BRANCH = process.env.GIT_BRANCH === 'origin/master' ? 'master' : process.env.GIT_BRANCH;
process.env.PERCY_TOKEN = '***';
process.env.PERCY_PROJECT = '***';

cli.run([
  '--build_dir=storybook-content',
  '--widths = 320, 1280'
]).then(() => {
  process.on('exit', () => process.exit(0));
})
.catch(err => {
  console.log('Error: ', err); // eslint-disable-line no-console
  process.on('exit', () => process.exit(1));
});

which I now use to run from NPM. Works for now, but would be awesome if Percy did the smart work.

[juanse417]

I have the same issue.

Ended up setting PERCY_BRANCH env variable directly on Jenkinsfile when building on master.