Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 4 from appveyor tests #75

Merged
merged 1 commit into from Sep 13, 2018
Merged

Conversation

maprules1000
Copy link
Contributor

Node 4 was removed from the travis pipeline and this removes it from the appveyor pipeline. It was causing some flakey tests because some of addons have deprecated node 4 support.

Copy link
Contributor

@fotinakis fotinakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@fotinakis fotinakis merged commit 182d240 into master Sep 13, 2018
@maprules1000 maprules1000 deleted the map/remove-node-4-appveyor branch September 13, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants