Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable gocognit linter rule #2343

Open
1 task done
ademidoff opened this issue Jul 3, 2023 · 0 comments
Open
1 task done

Enable gocognit linter rule #2343

ademidoff opened this issue Jul 3, 2023 · 0 comments
Assignees
@BupycHuk @artemgavrilov
Labels
enhancement good first issue Good issue for newcomers hacktoberfest

Comments

@ademidoff
Copy link
Member

ademidoff commented Jul 3, 2023 •
edited

Description

Ref: #1541
We'd like to enable gocognit linter rule.

Suggested solution

  • evaluate if we can afford to enable the rule
  • if yes, fix all linter error to make tests pass
  • if not, disable the rule and leave a comment explaining why (subject to review by the dev team)

Additional context

The rule can be enabled by simply removing this line.
You can check similar PRs to see how we enabled some other rules (ref: #1541)

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BupycHuk BupycHuk

@artemgavrilov artemgavrilov

Labels
enhancement good first issue Good issue for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ademidoff @BupycHuk @artemgavrilov