Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address the gocritic linter warnings #2291

Open
1 task done
ademidoff opened this issue Jun 21, 2023 · 2 comments
Open
1 task done

Address the gocritic linter warnings #2291

ademidoff opened this issue Jun 21, 2023 · 2 comments
Assignees
@JiriCtvrtka
Labels
enhancement good first issue Good issue for newcomers hacktoberfest

Comments

@ademidoff
Copy link
Member

Description

We silenced a number of gocritic rule warnings in this PR to reduce the scope. However, addressing some of the warnings could simplify and optimize the code (see this conversation).

Suggested solution

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@ademidoff ademidoff added enhancement good first issue Good issue for newcomers feature Feature request labels Jun 21, 2023
@ademidoff ademidoff mentioned this issue Jun 21, 2023
Merged
@ademidoff ademidoff removed the feature Feature request label Jun 21, 2023
@Rajan-226
Copy link

Hey, Can I pick this?

@Rajan-226
Copy link

Rajan-226 commented Dec 2, 2023 •
edited

@ademidoff @BupycHuk Can I pick this?
I'm looking for start contributing to percona, so looking for good first issues. LMK if you've any other tasks as well which can help me onboard fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JiriCtvrtka JiriCtvrtka

Labels
enhancement good first issue Good issue for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ademidoff @BupycHuk @artemgavrilov @Rajan-226 @JiriCtvrtka