Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure auth strategies from SecretsManager and SSM ParameterStore for each AuthStrategy #9

Open
pflorek opened this issue Oct 31, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@pflorek
Copy link
Member

pflorek commented Oct 31, 2022

The current implementation offers the ability to fully configure the GitHub AuthStrategies either by SecretsManager or SSM ParameterStore for GitHub App (with installationId), a PAT or unauthenticated

https://github.com/octokit/authentication-strategies.js/#authentication-strategiesjs

See also https://github.com/pepperize/cdk-github/blob/main/API.md#static-functions--1

auth strategy description
appAuth GitHub App or installation authentication.
tokenAuth Personal Access Token authentication.
unauthenticated unauthenticated.

Do we have to support additional AuthStrategies. Or by different AWS Service i.e. AuthOptions.tokenAuthFromSecret(secret: ISecret), AuthOptions.tokenAuthFromParameter(parameter: IParameter)

@pflorek pflorek added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant