Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Gateway #86

Closed
nsheff opened this issue Feb 9, 2023 · 7 comments
Closed

Bad Gateway #86

nsheff opened this issue Feb 9, 2023 · 7 comments
Labels
bug Something isn't working likely solved

Comments

@nsheff
Copy link
Contributor

nsheff commented Feb 9, 2023

Latest error:

[INFO] [11:25:01] Initializing connection to pephub...
[INFO] [11:25:01] Connected successfully!
Traceback (most recent call last):
  File "/usr/local/bin/pephub", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/site-packages/pephub/main.py", line 105, in main
    uvicorn.run(
TypeError: run() got an unexpected keyword argument 'debug'

@nsheff nsheff added the bug Something isn't working label Feb 9, 2023
@nsheff
Copy link
Contributor Author

nsheff commented Feb 9, 2023

It looks like debug may have been removed in a recent update to uvicorn.

Did we also update uvicorn in this release?

https://github.com/encode/uvicorn/blob/master/CHANGELOG.md

@nsheff
Copy link
Contributor Author

nsheff commented Feb 9, 2023

This PR talks about removing the CLI --debug... it doesn't say anything about the debug argument to the run function, but maybe they are related?

encode/uvicorn#1640

@nleroy917
Copy link
Member

I forgot that we deploy using the cli entry point not the standard uvicorn pephub.main.

It's possible. The cli interface to pephub has definitely been neglected

@nleroy917
Copy link
Member

We arnt pinning uvicorn to a version so if they updated it to not include debug as a kwarg then that makes sense

@nsheff
Copy link
Contributor Author

nsheff commented Feb 9, 2023

Is this something you can correct this morning?

@nleroy917
Copy link
Member

Attempting now.

@nleroy917
Copy link
Member

I think this is now solved with the latest release and DNS configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working likely solved
Projects
None yet
Development

No branches or pull requests

2 participants