Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tomll): add multiLineArray flag to linter #578

Merged
merged 1 commit into from Sep 6, 2021

Conversation

rasta-rocket
Copy link

Hi 👋

First of all, thanks for your work on this project 💪.

We use the linter in our CI and thanks to that we have been able to keep the quality of our TOML files.

Since things started to get serious, we have moore and more bigger arrays that became hard to maintain since the linter keep the arrays in one line.

Explanation of what this pull request does.

The goal of this PR is to add a flag to the linter that allow us to render the TOML file with multulines array (meaning one line by element)

Don't hesitate if you need more details

Cheers 😉

@pelletier
Copy link
Owner

Thank you! it does seem useful.

@pelletier pelletier merged commit b8ba995 into pelletier:master Sep 6, 2021
@rasta-rocket
Copy link
Author

Thanks for the quick review @pelletier 🎉

Question : would it be possible to you to make a new release with that ?

Cheers 😉

@pelletier
Copy link
Owner

Done! https://github.com/pelletier/go-toml/releases/tag/v1.9.4

@rasta-rocket
Copy link
Author

@pelletier Sorry me again 😅 : the binaries are missing in the release, are you able to provide them ?

Thanks 🙏

@pelletier
Copy link
Owner

🤦🏻‍♂️ I apologize, looks like the release pipeline is broken. I've manually added the binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants