Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short-date support #298

Merged
merged 7 commits into from Oct 25, 2019
Merged

Short-date support #298

merged 7 commits into from Oct 25, 2019

Conversation

pelletier
Copy link
Owner

@pelletier pelletier commented Sep 17, 2019

Issue: #63 #231

Implementation of short date and non-timezone-aware date support.

This first implementation uses cloud.google.com/go/civil to represent civil dates. However, turns out importing this package pulls a lot of Google's dependencies, which I don't want to do. civil will need to be extracted and bundled with go-toml.

Todo

  • Update date regexp in lexer
  • Lex localDate token
  • Bundle civil in go-toml without other dependencies
  • Marshal support
  • Unmarshal support

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #298 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   94.21%   94.55%   +0.34%     
==========================================
  Files           9       10       +1     
  Lines        1901     2020     +119     
==========================================
+ Hits         1791     1910     +119     
  Misses         66       66              
  Partials       44       44
Impacted Files Coverage Δ
token.go 100% <ø> (ø) ⬆️
lexer.go 98.78% <100%> (+0.01%) ⬆️
tomltree_write.go 95.25% <100%> (+0.03%) ⬆️
marshal.go 92.42% <100%> (+0.08%) ⬆️
parser.go 91.79% <100%> (+0.61%) ⬆️
localtime.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5edf9ac...a97ced5. Read the comment docs.

@pelletier pelletier force-pushed the short-date-suport branch 2 times, most recently from 144600f to 67c7f86 Compare September 24, 2019 23:19
@pelletier pelletier mentioned this pull request Oct 25, 2019
@pelletier pelletier marked this pull request as ready for review October 25, 2019 17:19
@pelletier pelletier merged commit 8a362ad into master Oct 25, 2019
@pelletier pelletier deleted the short-date-suport branch October 25, 2019 17:21
@pelletier pelletier mentioned this pull request Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant