From e6c0d393f2de987e7ad33198085b2173ea9a9cd3 Mon Sep 17 00:00:00 2001 From: Johannes Ewald Date: Sat, 16 May 2020 14:50:49 +0200 Subject: [PATCH] feat: Remove Prettier configuration BREAKING CHANGE: Based on discussion https://github.com/peerigon/eslint-config-peerigon/issues/76 we decided to remove our Prettier configuration. In order to avoid useless discussions, people should format their code with thatever style Prettier uses. Configuring Prettier ultimately defeats the purpose of Prettier, see https://github.com/prettier/prettier/issues/40 --- README.md | 6 ------ prettier-spaces.js | 9 --------- prettier.js | 22 ---------------------- 3 files changed, 37 deletions(-) delete mode 100644 prettier-spaces.js delete mode 100644 prettier.js diff --git a/README.md b/README.md index 05e00cb..da81ef2 100644 --- a/README.md +++ b/README.md @@ -468,12 +468,6 @@ const foo: Array = []; ## Prettier -There is a [Prettier](https://prettier.io/) config in this repository that corresponds to our linting rules as much as possible. Add a `.prettierrc` file to your repository with the following content: - -```js -"eslint-config-peerigon/prettier" -``` - In order to avoid conflicts between Prettier and our rules, you should always add **prettier rules at the end of `extends`**. For example, in a TypeScript + React project you would use the following configuration: ```js diff --git a/prettier-spaces.js b/prettier-spaces.js deleted file mode 100644 index 7c9aa13..0000000 --- a/prettier-spaces.js +++ /dev/null @@ -1,9 +0,0 @@ -"use strict"; - -const prettier = require("./prettier.js"); - -module.exports = { - ...prettier, - tabWidth: 4, - useTabs: false, -}; diff --git a/prettier.js b/prettier.js deleted file mode 100644 index 7dd7c30..0000000 --- a/prettier.js +++ /dev/null @@ -1,22 +0,0 @@ -"use strict"; - -module.exports = { - printWidth: 80, - // When we're using Prettier, we can also just use tabs. - // This way every developer is free to configure their - // preferred indentation width. - useTabs: true, - semi: true, - singleQuote: false, - quoteProps: "as-needed", - jsxSingleQuote: false, - trailingComma: "all", - bracketSpacing: false, - jsxBracketSameLine: false, - // Adding a parameter to an arrow functions becomes easier when we add parens all the time. - arrowParens: "always", - proseWrap: "preserve", - htmlWhitespaceSensitivity: "css", - vueIndentScriptAndStyle: true, - endOfLine: "lf" -};